Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pager] Support offscreenPageLimit #899

Closed
lsuski opened this issue Dec 1, 2021 · 12 comments
Closed

[Pager] Support offscreenPageLimit #899

lsuski opened this issue Dec 1, 2021 · 12 comments
Assignees
Labels

Comments

@lsuski
Copy link

lsuski commented Dec 1, 2021

Is your feature request related to a problem? Please describe.
Currently to achieve with HorizontalPager displaying partially next/previous page we have to define contentPaddings. However it is not always desirable. With ViewPager2 we can manipulate page in page transformer (e.g set transalationX) along with offscreenPageLimit = 1

Describe the solution you'd like
HorizontalPager and VerticalPager should support offscreenPageLimit the same as ViewPager2 does

@lsuski lsuski added the enhancement New feature or request label Dec 1, 2021
@andkulikov andkulikov self-assigned this Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Jan 1, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Jan 1, 2022
@github-actions github-actions bot closed this as completed Jan 6, 2022
@lsuski
Copy link
Author

lsuski commented Jan 6, 2022

Is this closed just because of inactivity?

@andkulikov andkulikov removed the stale Stale issues which are marked for closure label Jan 10, 2022
@andkulikov andkulikov reopened this Jan 10, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Feb 10, 2022
@andkulikov andkulikov added waiting on dependency and removed stale Stale issues which are marked for closure labels Feb 14, 2022
@Nek-12
Copy link

Nek-12 commented Jul 13, 2022

On what exact dependency are we waiting for in this issue?

@andkulikov
Copy link
Collaborator

https://issuetracker.google.com/issues/172029355

@andkulikov
Copy link
Collaborator

Please use the bug above to track that. Once we have that in lazy lists we will add this functionality in the new Pager we are working on for Compose UI

@mtotschnig
Copy link

@andkulikov The linked issue is fixed since October 17. By "new Pager for Compose UI", do you mean a different component than this library's pager? If yes, is there any information on a roadmap for this component? If no, is there any information when Accompanist's pager will take up the new LazyList offscreen capacity?

@andkulikov
Copy link
Collaborator

@mtotschnig hey, we are currently designing a new Pager component which will live right in compose.foundation and it will be a replacement for Accompanist's Pager. We are planning to provide an experimental version of this component in Compose 1.4. It will have an api for setting offscreenPageLimit

@arnaudlvq
Copy link

@andkulikov in 2024, how can we set offscreenpagelimit ? seems like it has been removed

@andkulikov
Copy link
Collaborator

Accompanist Pager is deprecated, please use a HorizontalPager available in the main compose:foundation library. This component has a param for this functionality

@arnaudlvq
Copy link

thank you @andkulikov, you helped me persevere, for those who are lost :

It has been renamed : beyondBoundsPageCount

https://www.composables.com/foundation/horizontalpager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants