Failing while building java-allocation-instrumenter version 3.3.0 using mvn clean install (java-allocation-instrumenter3.3.0)

[shivsrivastava]

Package artifact id: allocation-instrumenter

source code url: https://github.com/google/allocation-instrumenter/tree/java-allocation-instrumenter-3.3.0

Issue Description: Failing while building java-allocation-instrumenter version 3.3.0 using mvn clean install (java-allocation-instrumenter3.3.0)

JDK Version: 1.8

Build CMD: mvn clean install

MVN Version: 3.9.6

gradle version - NA

Error Log:

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ConstructorInstrumenterTest.testSubclassesAlso:76 Did not see correct number of BasicFunctions expected:<2> but was:<0>
[ERROR] Errors:
[ERROR] AllocationInstrumenterTest.testTooBig:37 » NullPointer com/google/monitoring/runtime/instrumentation/MuchTooBig.class
[ERROR] ConstructorInstrumenterTest.testBasicFunctionality:46 » NullPointer
[ERROR] ConstructorInstrumenterTest.testThreads:28 » NullPointer
[INFO]
[ERROR] Tests run: 7, Failures: 1, Errors: 3, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

attachement: build log attached (jdk 1.8)
Failed_java_8_logs.txt

OS: windows 10

[cpovirk]

Similar to google/guava#7172, we won't go back and change the code at an existing tag. I grant that this one is more embarrassing, since I don't know if these tests worked at all at that tag :\

Unlike in the Guava case, I don't know that there's an easy fix: We subsequently switched the build from Maven to Bazel, so you might have to cherry-pick a whole series of commits in order to get that new build system working :(

[shivsrivastava]

Hi @cpovirk , Thanks for update . I was looking for that specific commit from where all test cases are passing. Can you please help me on this?

[cpovirk]

Hmm, I have to go all the way to https://github.com/google/allocation-instrumenter/tree/java-allocation-instrumenter-3.3.4 before they pass. I wonder if it would work at older commits if I used an older version of Bazel? Currently, I'm using Bazel 7.1.1 and testing with bazel test //....

Also, I forgot to say this yesterday: I wonder if it would be possible to get the old Maven tests to pass if Maven were configured to actually attach the allocation-instrumenter agent during tests. That sounds like it might not be hard to do, but I haven't looked into it because I don't actually know if it would work in the end.