Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDC catalog app: Not enough padding between title and dropdown / DateTime #1417

Closed
shelaghm opened this issue May 25, 2022 · 4 comments · Fixed by #1459
Closed

SDC catalog app: Not enough padding between title and dropdown / DateTime #1417

shelaghm opened this issue May 25, 2022 · 4 comments · Fixed by #1459
Assignees
Labels
effort:xsmall Extra small effort - 1 day P2 Medium priority issue type:bug Something isn't working ux

Comments

@shelaghm
Copy link

Describe the bug
The padding should be 24px between title and dropdown element.

Component
SDC gallery app

To Reproduce
Steps to reproduce the behavior:

  1. Go to SDC catalog app
  2. Click on dropdown

Screenshot_20220524-145621

Screen Shot 2022-05-24 at 22 53 00

@shelaghm shelaghm added type:bug Something isn't working Data capture ux labels May 25, 2022
@shelaghm
Copy link
Author

Same issue on DateTime picker
Screenshot_20220524-145927

@shelaghm shelaghm changed the title SDC catalog app: Not enough padding between title and dropdown SDC catalog app: Not enough padding between title and dropdown / DateTime May 25, 2022
@Tarun-Bhardwaj Tarun-Bhardwaj added P2 Medium priority issue effort:xsmall Extra small effort - 1 day labels May 25, 2022
@santosh-pingle santosh-pingle self-assigned this Jun 16, 2022
@santosh-pingle
Copy link
Collaborator

In progress.

@jingtang10
Copy link
Collaborator

@shelaghm 1) how big should the gap be between the last input widget of the previous question and the question title of the next question 2) if there's subtext to a question title, how big should the gap be between the question title and the subtext, and the subtext and the input widget below the subtext?

@santosh-pingle these things determine if you should implement the gap on the question title, or on the subtext, or the input widget. beacuse if there's no question title, for example, or no subtext, you still want things to look uniform.

@shelaghm
Copy link
Author

Screen Shot 2022-06-21 at 15 50 35

This mockup should help answer the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:xsmall Extra small effort - 1 day P2 Medium priority issue type:bug Something isn't working ux
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants