Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review button doesn't validate the last page of a paginated questionnaire #1682

Closed
KhumboLihonga opened this issue Oct 20, 2022 · 10 comments · Fixed by #1894
Closed

Review button doesn't validate the last page of a paginated questionnaire #1682

KhumboLihonga opened this issue Oct 20, 2022 · 10 comments · Fixed by #1894
Assignees
Labels
P1 High priority issue type:bug Something isn't working

Comments

@KhumboLihonga
Copy link

KhumboLihonga commented Oct 20, 2022

Describe the bug
In a paginated questionnaire that uses the entryMode extension set to prior-edit, the active page needs to be valid before moving to the next page. When used in conjunction with the review functionality, the next button turns into a review button on the final page of the paginated questionnaire. And when this review button is tapped, no validation takes place on this page. An example of this is shown in the video below.

Component
SDC Library

To Reproduce
N/A

Expected behavior
I expect the review button to validate the last page before allowing the user to proceed to the review page.

Screenshots
In the video below, the user is first tapping the next button on each page to show the validation erros before entering the required information. Once this is done, the next button is tapped to proceed to the next page. But on the final page (with the heading CHW Assignment), on tapping the review button, no validation is done.

20221020_120603.mp4

Smartphone (please complete the following information):

  • Device: Samsung A12
  • Android version: 11
  • Build number: RP1A.200720.012.A127FXXU4AUK1
  • Version: 30

Additional context
Here is the questionnaire being used in the video:

@Gental-Giant
Copy link

@f-odhiambo Can you take a look and advice?

@jingtang10
Copy link
Collaborator

@KhumboLihonga which version of the sdc lib are you using?

@jingtang10 jingtang10 added type:bug Something isn't working P1 High priority issue labels Oct 27, 2022
@KhumboLihonga
Copy link
Author

@jingtang10 org.smartregister:data-capture:0.1.0-beta05-preview4-SNAPSHOT

@jingtang10
Copy link
Collaborator

i see this is opensrp's fork. can you try depending on beta06 of the sdc lib?

@KhumboLihonga
Copy link
Author

@LZRS Could you look into updating this

@KhumboLihonga
Copy link
Author

@jingtang10 we tried using beta06 as per opensrp/fhircore#1836 but it's still not working as shown in the video below.

20221115_104422.mp4

@aditya-07
Copy link
Collaborator

@KhumboLihonga @jingtang10 PR-1671 would solve this issue. Its not merged yet.

@KhumboLihonga
Copy link
Author

@aditya-07 @jingtang10 I tested this once again since #1671 has now been merged but I'm still facing the same issue. Here is a video showing the issue after testing the it again. And here is the questionnaire that I used.

@jingtang10
Copy link
Collaborator

i have verified on HEAD, this is still broken.

@KhumboLihonga
Copy link
Author

@jingtang10 thanks for verifying this. Is there an ETA on when this could get resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue type:bug Something isn't working
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

4 participants