Support max length and min length

[jingtang10]

In our views for different question types, we need to validate the lengths of the answers by respecting the min and max length constraints.

The max length constraint is part of the Questionnaire resource in FHIR: https://www.hl7.org/fhir/questionnaire-definitions.html#Questionnaire.item.maxLength
The min length constarint is part of the structured data capture implementation guide (SDC IG): http://hl7.org/fhir/uv/sdc/2019May/behavior.html#value-constraints Notice the difference: it's an extension, not part of the core resource.

@kunjan8794 already created a validation framework: https://github.com/google/android-fhir/tree/master/datacapture/src/main/java/com/google/android/fhir/datacapture/validation

We will need to create possibly 2 more validators, which will be triggered if the max length field is set or the min length extension exists.

The result of the validation will then be displayed in the UI in the appropriate places in different types of input.

To begin with, we can probably focus on EditText types of controls.

[Manikant25]

Can I work on the issue?

[pankajkatoch]

Can I work on the issue?

Hi Manikant,
If you have a context and background of this project, and have some knowledge of FHIR, then sure go ahead.
Otherwise I had planned to handle it next week.

Thanks.

[s-ayush2903]

@Manikant25 We already have a PR for this, see #224

[Manikant25]

Can I work on the issue?

Hi Manikant,
If you have a context and background of this project, and have some knowledge of FHIR, then sure go ahead.
Otherwise I had planned to handle it next week.

Thanks.

No, I don't know much about the project if you are doing keep doing.
Thanks

[Manikant25]

@Manikant25 We already have a PR for this, see #224

@s-ayush2903 Thanks for informing me.

[jingtang10]

#224 is about min and max value rather than min and max length.

@pankajkatoch do you have an estimated date for this one?

thanks all!

[sakets3010]

@jingtang10 i would like to work upon this issue, if its still available.
material text views have a functionality to add max and min limit for fields, do let me know if you had some other implementation in mind.

[kunjan8794]

@jingtang10 Should I take this up next?

[jingtang10]

@jingtang10 i would like to work upon this issue, if its still available.
material text views have a functionality to add max and min limit for fields, do let me know if you had some other implementation in mind.

Note this item is about the max length of the string field - it's not about the max min value.

[jingtang10]

@sakets3010 will you be able to work on this? @kunjan8794 might be able to help since he implemented the validator framework.

[sakets3010]

@sakets3010 will you be able to work on this? @kunjan8794 might be able to help since he implemented the validator framework.

Hi @jingtang10 , I wont be able to work on this immediately. Pleases feel free to reassign. Apologies.

[kunjan8794]

@jingtang10 In that case, should I take this up next?