Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show required text if the question must be answered. Otherwise, provide configuration to support optional text. #1954

Closed
santosh-pingle opened this issue Apr 5, 2023 · 6 comments · Fixed by #1963
Assignees
Labels
effort:small Small effort - 2 days P2 Medium priority issue type:enhancement New feature or request ux

Comments

@santosh-pingle
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
As per the discussion with @shelaghm and @jingtang10, and considering the input from the external community, it has been decided that

  1. If a question item is required, then the required text will be shown in the form just below the view. This will be the default behavior.
  2. Also support the configuration to show optional text for optional questions instead of the default behavior.

#544

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle santosh-pingle added type:enhancement New feature or request P2 Medium priority issue ux effort:small Small effort - 2 days labels Apr 5, 2023
@santosh-pingle santosh-pingle self-assigned this Apr 10, 2023
@santosh-pingle
Copy link
Collaborator Author

Looking into it.

@santosh-pingle
Copy link
Collaborator Author

santosh-pingle commented Apr 10, 2023

@shelaghm

If there are instructions for a required question, is there a specific order or precedence to follow when displaying the required text for views like Single, Boolean and Multiple choice views?
Currently, if the required text is shown, it overrides existing instructions. To resolve this conflict, we need to decide how to show the required text along with instructions, if present.

@shelaghm
Copy link

I suggest showing 'required' text first, and then the rest of the instructions or entryFormat. Screenshot below. What do you think?

Screenshot 2023-04-10 at 15 13 40

@santosh-pingle
Copy link
Collaborator Author

I suggest showing 'required' text first, and then the rest of the instructions or entryFormat. Screenshot below. What do you think?

Screenshot 2023-04-10 at 15 13 40

Thanks!
yes, I am also of the same opinion to show the required text and instructions in the same line, if both are present.

@santosh-pingle
Copy link
Collaborator Author

@shelaghm

If optional text is configured, but question text is not provided in the questionnaire, then I am of the opinion that optional text should not be shown as the only question text.

Do you have any suggestions?

Note: Please refer to the attached screenshots from the link below for (optional) text configuration.

@shelaghm
Copy link

shelaghm commented Apr 12, 2023

Non-text field options: I think it's rare there won't be a title, so I propose we ignore this edge case
Text field: I suggest we show in the EntryFormat (option 1) or alternatively in the label text (option 2)

Screenshot below
Screenshot 2023-04-12 at 15 49 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:small Small effort - 2 days P2 Medium priority issue type:enhancement New feature or request ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants