Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display prefixes in questions #202

Closed
jingtang10 opened this issue Jan 31, 2021 · 15 comments · Fixed by #333
Closed

Display prefixes in questions #202

jingtang10 opened this issue Jan 31, 2021 · 15 comments · Fixed by #333
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed type:enhancement New feature or request

Comments

@jingtang10
Copy link
Collaborator

jingtang10 commented Jan 31, 2021

See the pain management questionnaire #196

Spec: https://www.hl7.org/fhir/questionnaire-definitions.html#Questionnaire.item.prefix

At the moment the prefixes are not displayed at all, this causes confusion in some questions where the prefix includes critical information.

@jingtang10 jingtang10 added type:enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 31, 2021
@jingtang10 jingtang10 added this to To do in Data capture library via automation Jan 31, 2021
@joiskash joiskash self-assigned this Feb 4, 2021
@joiskash
Copy link
Collaborator

joiskash commented Feb 4, 2021

For True/False answers rendered as a check box, where will the prefix come? Seems odd if it looks like "Q2 | | Are you feeling happy?"
PS: | | is a checkbox

@jingtang10 jingtang10 moved this from To do to In progress in Data capture library Feb 9, 2021
@jingtang10 jingtang10 moved this from In progress to To do in Data capture library Feb 9, 2021
@MuhammadSalman-7214
Copy link
Contributor

@jingtang10 where do we want to show prefixes in questions ? please specify. Thanks

@jingtang10
Copy link
Collaborator Author

@MuhammadSalman-7214 yes that's the main focus of this issue. At the moment the prefixes are not handled/shown.

@jingtang10 jingtang10 changed the title Handle prefixes in questions Display prefixes in questions Mar 11, 2021
@jingtang10
Copy link
Collaborator Author

updated the description.

@MuhammadSalman-7214
Copy link
Contributor

MuhammadSalman-7214 commented Mar 11, 2021

so, we want to show prefix for every question or with only specific question @jingtang10 ?

@jingtang10
Copy link
Collaborator Author

I believe by default we should just show it for all questions. no reason to hide it for some questions. What do you think?

If you have doubts please feel free to use https://chat.fhir.org/#narrow/stream/179255-questionnaire to ask quesitons about the expecation of the standard itself.

What I'm not sure about is if we should use two different text views or concatenate the strings in one text view. Can you think aboout the pros and cons and write down your thoughts here @MuhammadSalman-7214? Thanks!

@MuhammadSalman-7214
Copy link
Contributor

One thing is if we want to show prefix for each questionnaire, then we have to add the code in all the factory classes to show prefix with question, right @jingtang10 ?

I think rather than two different textviews, we should concatenate the prefix before question text, it's advantage is that we do not have to change xml at all, only the code files will change

@jingtang10
Copy link
Collaborator Author

jingtang10 commented Mar 11, 2021

Yes this will touch all view types.

I'm not sure I necessarily agree we should simply do the easiest thing.

One important consideration is that if the prefix needs to be rendered differently (e.g. different color, size, font) then we would not be able to achieve that if it is in the same text view as the question's text. Do you know if there's ever an expectation that it might need to be rendered differently? Can you do some research to figure this out?

@MuhammadSalman-7214
Copy link
Contributor

I understand your point, but from where should I research or from where should I ask
https://chat.fhir.org/login/#narrow/stream/179255-questionnaire
should I ask on this link?

@s-ayush2903
Copy link
Contributor

I think rather than two different textviews, we should concatenate the prefix before question text, it's advantage is that we do not have to change xml at all, only the code files will change

I have a question, why we don't want to change XML? I believe it can be done with a little more effort using the data binding and conditionally adding the prefixes to the text needed

@MuhammadSalman-7214
Copy link
Contributor

it's not that we don't want to change the xml, currently we are discussing the solutions

@MuhammadSalman-7214
Copy link
Contributor

so how are we going about it @jingtang10 ?

@jingtang10
Copy link
Collaborator Author

did you get a chance to ask the question in the zulip chat stream?

as i said i'm concerned about the customization of styling for prefix and the main question text. so having 2 different views gives more flexibility.

@MuhammadSalman-7214
Copy link
Contributor

posted it just now in the zulip chat stream

so should I start to add text views in every factory class then @jingtang10 ?

@jingtang10
Copy link
Collaborator Author

@MuhammadSalman-7214 MuhammadSalman-7214 linked a pull request Mar 16, 2021 that will close this issue
@jingtang10 jingtang10 moved this from To do to In progress in Data capture library Mar 19, 2021
Data capture library automation moved this from In progress to Done Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed type:enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants