Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modification of Questionnaire submit action button text via configuration #2239

Closed
ellykits opened this issue Oct 9, 2023 · 3 comments · Fixed by #2319
Closed

Allow modification of Questionnaire submit action button text via configuration #2239

ellykits opened this issue Oct 9, 2023 · 3 comments · Fixed by #2319

Comments

@ellykits
Copy link
Collaborator

ellykits commented Oct 9, 2023

Is your feature request related to a problem? Please describe.
As part of the enhancement, we'd like to set the text for the submit action button via configuration.

Describe the solution you'd like
Expose a function/property etc. to allow modification of the submit action button text.

Describe alternatives you've considered
For the set save button text, we can findTheViewById and apply the text as desired but this will be subject to code changes.

Additional context
In order to filter the content of our registers (list of resources) we opted to re-use the UI rendered via Questionnaires instead of implementing custom UI to capture the content for the filter. As part of the requirement a configuration to change the text for the submit action to "APPLY FILTERS" is needed.

See the screenshot below, the Questionnaire is the second screen in the pic.

image (1)

Would you like to work on the issue?
Yes

@MJ1998
Copy link
Collaborator

MJ1998 commented Nov 15, 2023

The app bar is not controlled by the QuestionnaireFragment. You can probably achieve this by customizing app bar in your application for this particular fragment where you are hosting the QuestionnaireFragment as its child fragment. Example is this older version of ScreenerFragment

Or am I missing something ?

@DebbieArita
Copy link
Contributor

@MJ1998 For this issue, we're trying to make the submit action button text on the QuestionnaireFragment configurable. Reference the second screen whose action button reads 'APPLY FILTERS'. There are cases where I want to be able to override the default 'SUBMIT' text and have any other text on the action button. The app bar issue will be addressed here. I hope that clarifies.

@f-odhiambo
Copy link
Collaborator

@DebbieArita has an open PR on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

4 participants