Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions which have multiline text cannot be read completely in the dropdown and edittext widget #226

Closed
joiskash opened this issue Feb 9, 2021 · 17 comments · Fixed by #272
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed type:bug Something isn't working

Comments

@joiskash
Copy link
Collaborator

joiskash commented Feb 9, 2021

Long questions cannot be read completely.

eg: "How much pain is the patient in,please select any of the options below?"

Appears as "How much pain is the patient in,please select any..."

Originally reported by @kumaakh

@joiskash joiskash added type:bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 9, 2021
@joiskash joiskash added this to To do in Data capture library via automation Feb 9, 2021
@joiskash joiskash changed the title Questions which are long cannot be read completely in the dropdown widget Questions which have multiline text cannot be read completely in the dropdown widget Feb 9, 2021
@jingtang10
Copy link
Collaborator

@joiskash can you add a screenshot for this?

I think the solution is that we need to use a separate view (text view) for the question text. the hint field in the text input layout itself is too small. @fredhersch for input.

@joiskash
Copy link
Collaborator Author

Screenshot_20210209-164420.jpg

@jingtang10
Copy link
Collaborator

I don't think this is blocking the alpha01. @jtournier23 for comment. @joiskash does this block you from testing this lib?

@joiskash
Copy link
Collaborator Author

It does not block us from testing the library but it surely is a high priority task .

@jingtang10 jingtang10 moved this from To do to In progress in Data capture library Feb 17, 2021
@jingtang10
Copy link
Collaborator

@MuhammadSalman-7214 can you take a look at this please?

@MuhammadSalman-7214
Copy link
Contributor

We can also set hint to autoCompleteTextView rather than textInputLayout, because setting hint to autoCompleteTextView shows text completely no matter how long it is

@MuhammadSalman-7214
Copy link
Contributor

Me and @jingtang10 decided to go with TextView as a Question and then the autoCompleteTextView below the question TextView for selecting the answer option. This way question will always be there with any length. @joiskash

@joiskash
Copy link
Collaborator Author

Me and @jingtang10 decided to go with TextView as a Question and then the autoCompleteTextView below the question TextView for selecting the answer option. This way question will always be there with any length. @joiskash

Cool makes sense to me :)

@MuhammadSalman-7214
Copy link
Contributor

great then

@jingtang10
Copy link
Collaborator

Thanks both. @MuhammadSalman-7214 will you please make sure to post a screenshot here of your prototype before sending out PR? Cheers.

@MuhammadSalman-7214
Copy link
Contributor

your welcome, sure
Screenshot_1614003197

@jingtang10 jingtang10 linked a pull request Feb 24, 2021 that will close this issue
@jingtang10 jingtang10 changed the title Questions which have multiline text cannot be read completely in the dropdown widget Questions which have multiline text cannot be read completely in the dropdown and edittext widget Feb 24, 2021
@jingtang10
Copy link
Collaborator

thanks @MuhammadSalman-7214 for your work!

can you do the same for the edit text widget and then we can close this issue.

@MuhammadSalman-7214
Copy link
Contributor

your welcome @jingtang10, can you please tell me what exactly is required for edit text widget?

@jingtang10
Copy link
Collaborator

See the below example for date (and same for date+time) and edit text widgets

C7n5X2UcEckhqBB

@MuhammadSalman-7214
Copy link
Contributor

For date and edit text widgets, its done, but for date + time widgets, we are setting them in a horizontal linear layout which first takes date and then time, so do we want to change here as well as I am not seeing any example of date+time in the application @jingtang10 ?

@joiskash
Copy link
Collaborator Author

@MuhammadSalman-7214 There is an example, check the second questionnaire, the Neonate record . After you select an option for the Vitamin K given question, a new question will show up of type date+time

@MuhammadSalman-7214
Copy link
Contributor

MuhammadSalman-7214 commented Feb 25, 2021

Thanks @joiskash

Data capture library automation moved this from In progress to Done Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants