Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render questionnaire in different language using language extension #465

Closed
2 of 3 tasks
fredhersch opened this issue May 11, 2021 · 5 comments · Fixed by #478
Closed
2 of 3 tasks

Render questionnaire in different language using language extension #465

fredhersch opened this issue May 11, 2021 · 5 comments · Fixed by #478
Assignees
Labels
P1 High priority issue type:enhancement New feature or request
Milestone

Comments

@fredhersch
Copy link
Collaborator

fredhersch commented May 11, 2021

Is your feature request related to a problem? Please describe.
Support for language extensions within a FHIR questionnaire

Describe the solution you'd like

  • When given a Questionnaire with different language extensions, be able to render in the appropriate language based on the Android language settings
  • If no language extension is available for the local language, show the default language (usually English) for the item
  • Show related controls using the local language (from strings.xml) e.g. list selection options, back/forward (for multi-step questionnaire)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Issue #161 has link to the updated Questionnaire with Vietnamese translations

Would you like to work on the issue?
Happy to support

@fredhersch fredhersch added type:enhancement New feature or request P1 High priority issue labels May 11, 2021
@fredhersch fredhersch added this to To do in Data capture library via automation May 11, 2021
@aditya-07 aditya-07 self-assigned this May 11, 2021
@fredhersch
Copy link
Collaborator Author

See this issue #166 for discussion about implementing language support

@fredhersch
Copy link
Collaborator Author

@jingtang10 can we update this questionnaire in the SDC Gallery app and see this working?

@aditya-07
Copy link
Collaborator

@fredhersch I have already added the questionnaire in the SDC Gallery app and its available for everyone to checkout.

@fredhersch fredhersch added this to the sdc-alpha-03-m1 milestone May 24, 2021
@jingtang10 jingtang10 reopened this May 26, 2021
Data capture library automation moved this from Done to To do May 26, 2021
@jingtang10
Copy link
Collaborator

jingtang10 commented May 26, 2021

This isn't done yet as per @fredhersch's requirements:

  • Show related controls using the local language (from strings.xml) e.g. list selection options, back/forward (for multi-step questionnaire)

Might create a new issue for that instead.

@pld raised a question about custom locale rather than using android system locale. After testing I realized you can set it by using Locale.setLocale API in your activity/fragment. So I think this is entirely doable by implementers with the current library following @aditya-07 's change.

@fredhersch
Copy link
Collaborator Author

fredhersch commented May 27, 2021

@jingtang10 @aditya-07 I opened a new issue here - #503
Let's confirm if the Locale.setLocale API change will enable this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue type:enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants