-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support prefixes in search: eq, ne, gt, lt, ge, le #474
Comments
Update, working on this. Will open a pr soon. The challenging thing would be the a canonical match. For eg, a search for 5 grams should match 5000 mg. I think in order for this to work we'd have to make changes to the indexing code. Possibly add another column that stores the value in base units and then at the time or search convert the quantity into base units to search. |
@epicadk, thanks for the update. Is there an ETA you have for completing the code changes for this? |
I'm still searching for a library/any other solution that would help convert units to UCUM base units. I can get the rest of it done in around a week i.e. search on quantity types without canonical matches. |
@epicadk , were you able to move ahead with this issue? Any ETA that you can provide for completion? |
Sorry, slipped my mind, I'll open a pr that adds basic functionality by latest tomorrow. |
Thanks @epicadk. By adding basic functionality, are there any changes that are being excluded from the PR for now or would it cover the entire scope mentioned as part of this issue? I assigning it to a reviewer in the meantime. |
Yup, all functionality has been added except for |
FYI #568 |
Re-opened because still need to address #568. We could also close this and just have #568. @Tarun-Bhardwaj |
@epicadk , thanks Aditya. Let's keep this issue open until #568 is closed as both these issues are closely linked. Have assigned it to you. CC @jingtang10 |
Is your feature request related to a problem? Please describe.
https://www.hl7.org/fhir/search.html#prefix
Describe the solution you'd like
Design and implement the change to the search API
Describe alternatives you've considered
NA
Additional context
NA
Would you like to work on the issue?
No
The text was updated successfully, but these errors were encountered: