Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prefixes in search: eq, ne, gt, lt, ge, le #474

Closed
Tracked by #524
jingtang10 opened this issue May 14, 2021 · 12 comments · Fixed by #682
Closed
Tracked by #524

Support prefixes in search: eq, ne, gt, lt, ge, le #474

jingtang10 opened this issue May 14, 2021 · 12 comments · Fixed by #682
Assignees
Labels
P1 High priority issue type:enhancement New feature or request

Comments

@jingtang10
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
https://www.hl7.org/fhir/search.html#prefix

Describe the solution you'd like
Design and implement the change to the search API

Describe alternatives you've considered
NA

Additional context
NA

Would you like to work on the issue?
No

@jingtang10 jingtang10 added the type:enhancement New feature or request label May 14, 2021
@jingtang10 jingtang10 added this to To do in FHIR engine library via automation May 14, 2021
@epicadk
Copy link
Contributor

epicadk commented May 15, 2021

#436 & #419 add these prefixes for number and date. Is this what you had in mind or it is something else?

@Tarun-Bhardwaj Tarun-Bhardwaj added the P1 High priority issue label May 27, 2021
@epicadk epicadk self-assigned this Jun 28, 2021
@epicadk
Copy link
Contributor

epicadk commented Jun 28, 2021

Most of these are supported for Date and Number ( see #436 and #419 ) I'll add them for quantity types.

@epicadk
Copy link
Contributor

epicadk commented Jul 16, 2021

Update, working on this. Will open a pr soon. The challenging thing would be the a canonical match. For eg, a search for 5 grams should match 5000 mg. I think in order for this to work we'd have to make changes to the indexing code. Possibly add another column that stores the value in base units and then at the time or search convert the quantity into base units to search.
I think this library could help us achieve this. I don't think there is another way to convert random UCUM units to base units. However I can't seem to find documentation for the library and I'm not even sure if it is still under active development.

@Tarun-Bhardwaj
Copy link

@epicadk, thanks for the update. Is there an ETA you have for completing the code changes for this?

@epicadk
Copy link
Contributor

epicadk commented Jul 19, 2021

I'm still searching for a library/any other solution that would help convert units to UCUM base units. I can get the rest of it done in around a week i.e. search on quantity types without canonical matches.

@Tarun-Bhardwaj
Copy link

@epicadk , were you able to move ahead with this issue? Any ETA that you can provide for completion?

@epicadk
Copy link
Contributor

epicadk commented Aug 4, 2021

Sorry, slipped my mind, I'll open a pr that adds basic functionality by latest tomorrow.

@Tarun-Bhardwaj
Copy link

Thanks @epicadk. By adding basic functionality, are there any changes that are being excluded from the PR for now or would it cover the entire scope mentioned as part of this issue? I assigning it to a reviewer in the meantime.

@epicadk
Copy link
Contributor

epicadk commented Aug 5, 2021

Yup, all functionality has been added except for date~approximate as discussed here. #419 (comment). Will discuss with @jingtang10 and get that done as well. After that , it should not take more than a day to complete.

@epicadk
Copy link
Contributor

epicadk commented Aug 6, 2021

FYI #568

FHIR engine library automation moved this from To do to Done Aug 9, 2021
@epicadk epicadk reopened this Aug 9, 2021
FHIR engine library automation moved this from Done to In progress Aug 9, 2021
@epicadk
Copy link
Contributor

epicadk commented Aug 9, 2021

Re-opened because still need to address #568. We could also close this and just have #568. @Tarun-Bhardwaj

@Tarun-Bhardwaj
Copy link

Tarun-Bhardwaj commented Aug 9, 2021

Re-opened because still need to address #568. We could also close this and just have #568. @Tarun-Bhardwaj

@epicadk , thanks Aditya. Let's keep this issue open until #568 is closed as both these issues are closely linked. Have assigned it to you. CC @jingtang10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue type:enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants