Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the UI validation code in the SDC library #577

Open
jingtang10 opened this issue Jun 23, 2021 · 4 comments
Open

Refactor the UI validation code in the SDC library #577

jingtang10 opened this issue Jun 23, 2021 · 4 comments
Labels
help wanted Extra attention is needed P2 Medium priority issue type:enhancement New feature or request

Comments

@jingtang10
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Two issues:

  1. The UI validation is done by widgets in fairly arbritrary manner. This is bad because there might be divergence in the behaviour of different widgets.
  2. There is currently no way for the application to say - please validate all the answers in the questionnaire and display error messages according before questionnaire submission. We might need a new API for this.

Describe the solution you'd like
Discussed in #374.

Describe alternatives you've considered
NA

Additional context
Originally posted by @joiskash in #374 (comment)

Would you like to work on the issue?
NA

@jingtang10 jingtang10 added the type:enhancement New feature or request label Jun 23, 2021
@jingtang10 jingtang10 added this to To do in Data capture library via automation Jun 23, 2021
@kevinmost
Copy link
Contributor

We should consider pagination (#186) here, too.

As captured in this TODO, we should have an option to validate individual pages when the user clicks next/previous.

However, this shouldn't be required. Eg, if the form is being filled out as a draft, filling out all fields may not be required (or possible). However, when filling out the form in a context in which it will be submitted, the app developer may want to have page 1 validated before moving on to page 2, rather than having pages 1 and 2 validated at submission time.

@Tarun-Bhardwaj Tarun-Bhardwaj added this to the Q3 2021 milestone Jul 6, 2021
@Tarun-Bhardwaj Tarun-Bhardwaj added the help wanted Extra attention is needed label Jul 28, 2021
@Tarun-Bhardwaj Tarun-Bhardwaj added P2 Medium priority issue and removed Q3 2021 labels Sep 15, 2021
@Tarun-Bhardwaj Tarun-Bhardwaj removed this from the Q3 2021 milestone Dec 2, 2021
@aditya-07 aditya-07 self-assigned this Dec 30, 2021
@joiskash
Copy link
Collaborator

joiskash commented Feb 3, 2022

@aditya-07 have you started working on this? If not I can take it up. Its a high priority item for us.

cc: @jingtang10

@jingtang10 jingtang10 assigned joiskash and unassigned aditya-07 Feb 3, 2022
@jingtang10
Copy link
Collaborator Author

please feel free to go ahead @joiskash and thanks for taking this on

@joiskash joiskash removed their assignment Mar 31, 2022
@joiskash
Copy link
Collaborator

I am currently occupied with development work related to using the FHIR android SDK. Sorry, I do not have any bandwidth to work on this for the time being.

cc: @jingtang10 @Tarun-Bhardwaj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed P2 Medium priority issue type:enhancement New feature or request
Projects
Status: Icebox
Development

No branches or pull requests

5 participants