-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of $apply API #656
Comments
Few Observations during code exploration
Plz check commit here. These changes were required to run the library loaders. The test does not pass though due to expression not added as library (Not sure if I am missing anything here) |
Seem like we have the following Input
and gettging the following output based on @maimoonak updates Output Are you getting the same @jingtang10? |
Can we re-open this issue? I don't believe the above issues raised by @maimoonak and @f-odhiambo were addressed and tested. But maybe I am missing those tests, can you link to them? |
Thanks @pld for raising this. In the call earlier today we discussed this and @maimoonak will share the changes she has made and raise a draft pr against this issue. also would love to get input from jp and vitor (sent them invite to the repo). |
@f-odhiambo , though the associated PR #1195 is merged, what would it need to close this issue? |
I think we can track the $apply issues based on @vitorpamplona updates. I am ok closing this issue. Will update and coordinate with @maimoonak on where we can push the subsequent updates CC @Tarun-Bhardwaj |
Let's close this issue once we address everything in @maimoonak 's commit in her comment above. @maimoonak please close this issue or raise a PR if necessary. |
Current code has $apply unit test ignored hence we never knew that it is not working. the RuleFilters-1.0.0-bundle.json file might be collapsed into PR so plz expand to see the changes 1- Issue in cql library where it expects that the URL would be from server, however, by fhir definition it can be Canonical Local URL. Change PlanDefinition prefix / to -> "library": [ "Library/library-RuleFilters-1.0.0" ],
2- The cql loader internally work (compare and search) on library name so change the Library to correct reference i.e. "name": "RuleFilters" -> "name": "library-RuleFilters-1.0.0"
3- The
4- For
5- FhirEngineLibraryContentProvider updated to check for name and version if given, otherwise if version is null just return matching library by name
6- Unresolved
|
@vitorpamplona @brynrhodes can you help here please? |
Fixed on #1603 |
User story:
As an implementer I can use the $apply operation to generate a CarePlan for a patient given a PlanDefinition
Background
CQL (Clinical Quality Language) is the HL7 standard for providing logic execution for decision support and clinical quality measures.
Our initial goal with the CQL Library will be to demonstrate over time the ability to:
The text was updated successfully, but these errors were encountered: