Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question item was not hidden after adding hidden extension in item in questionnaire. #683

Closed
Tracked by #523
santosh-pingle opened this issue Aug 4, 2021 · 2 comments · Fixed by #742
Closed
Tracked by #523
Assignees
Labels
type:bug Something isn't working

Comments

@santosh-pingle
Copy link
Collaborator

santosh-pingle commented Aug 4, 2021

Describe the bug
After adding hidden extension to questionnaire, it does not hide questionnaire item while rendering the ui.

"extension": [
{
"url": "http://hl7.org/fhir/StructureDefinition/questionnaire-hidden",
"valueBoolean": "true"
}
],

  • If hidden extension is true, then question item will not be shown irrespective of whether it enabled or not.
  • If hidden extension is true and question item is enabled, then initial answers (if present) will be part of questionnaire response.
  • If hidden extension is false or not present, and question item is enabled, then question item will be shown.
  • If hidden extension is false or not present, and question item is not enabled, then question item will not be shown.

Component
SDC library

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
It should hide questionnaire item with hidden extension.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Pixel4a emulator]
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle
Copy link
Collaborator Author

In progress.
Will try to push PR in second half of today.

@santosh-pingle santosh-pingle changed the title sdc library does not support hidden extension. Question item was not hidden after adding hidden extension in item in questionnaire. Aug 20, 2021
@santosh-pingle
Copy link
Collaborator Author

I will try to push review changes by end of today which will have addressed review comments and updated unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants