Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring quantity index table by removing the canonical columns #733

Closed
jingtang10 opened this issue Aug 18, 2021 · 0 comments · Fixed by #900
Closed

Refactoring quantity index table by removing the canonical columns #733

jingtang10 opened this issue Aug 18, 2021 · 0 comments · Fixed by #900
Assignees
Labels
P1 High priority issue type:code health

Comments

@jingtang10
Copy link
Collaborator

I don't mind keeping only canonicalized quantities in Index. Could we make it explicit about not supporting case 4 in @epicadk comment?

Another possible option would be to not support canonical match at all as discussed with @jingtang10 . I think that makes more sense than this.

My guess is that it's unlikely for users to search by a quantity using the equal operator. I would imagine quantity would be used for sorting. But also probably used for search within a range.

If this is true, I would argue for canonicalisation. Although to make sorting work perfectly with different units there will be much more work.

Originally posted by @jingtang10 in #682 (comment)

@jingtang10 jingtang10 added this to To do in FHIR engine library via automation Aug 18, 2021
@Tarun-Bhardwaj Tarun-Bhardwaj added the P1 High priority issue label Oct 19, 2021
@jingtang10 jingtang10 self-assigned this Oct 28, 2021
@jingtang10 jingtang10 changed the title Refactoring quantity index table Refactoring quantity index table by removing the canonical columns Oct 29, 2021
@epicadk epicadk self-assigned this Nov 11, 2021
FHIR engine library automation moved this from To do to Done Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue type:code health
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants