Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile top-level field names with style guide #3

Closed
seaneagan opened this issue Dec 18, 2014 · 1 comment
Closed

Reconcile top-level field names with style guide #3

seaneagan opened this issue Dec 18, 2014 · 1 comment

Comments

@seaneagan
Copy link

https://www.dartlang.org/articles/style-guide/#prefer-using-lowercamelcase-for-constant-names

color_disabled is the biggest offender since it's not a constant, the others are a recent change to the style guide, which I'm not sure the entire dart community is aware of or in agreement with (but I personally am).
@jtmcdole
Copy link
Member

I personally hate ALL CAPS for consts. I can touch up the fields and leave the old ones with @deprecated

@lyceel lyceel closed this as completed in 462b7f8 Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seaneagan @jtmcdole