Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle task fetchAndUpdateFigmaFiles fails on integration tests #1028

Open
rylin8 opened this issue Apr 20, 2024 · 1 comment
Open

Gradle task fetchAndUpdateFigmaFiles fails on integration tests #1028

rylin8 opened this issue Apr 20, 2024 · 1 comment
Assignees
Labels
engProd Engineering productivity - build system, testing, etc 🟢 P2 Priority for next 2-3 releases

Comments

@rylin8
Copy link
Collaborator

rylin8 commented Apr 20, 2024

When running ./gradlew fetchAndUpdateFigmaFiles after making a breaking change to the serialized document format, the task fails because the integration tests on Interaction, VariantProperties and VariantAnimation fail. This may be because the tests are run on the old version of the .dcf file instead of run after fetching new ones.

In addition, it would be great if this task could also update:

  • Design Switcher .dcf file
  • Hello World .dcf file
  • Tutorial .dcf file (fetch the welcome one, then rename).

This would make it much easier to update all .dcf files, as I currently have to manually update these 6 files before running the task.

Error example:

com.android.designcompose.testapp.validation.AnimationMidpoints > variantAnimation FAILED
    java.lang.AssertionError: Failed to assert the following: (DocRenderStatus = 'Rendered')
    Can't retrieve node at index '0' of 'DocClass = 'com.android.designcompose.testapp.validation.examples.VariantAnimationTestGen''
    There are no existing nodes for that selector.
        at androidx.compose.ui.test.SemanticsNodeInteraction.fetchOneOrDie(SemanticsNodeInteraction.kt:175)
        at androidx.compose.ui.test.SemanticsNodeInteraction.fetchOneOrDie$default(SemanticsNodeInteraction.kt:150)
        at androidx.compose.ui.test.SemanticsNodeInteraction.fetchSemanticsNode(SemanticsNodeInteraction.kt:84)
        at androidx.compose.ui.test.AssertionsKt.assert(Assertions.kt:263)
        at androidx.compose.ui.test.AssertionsKt.assert$default(Assertions.kt:255)
        at com.android.designcompose.test.InstrumentedTestUtilsKt.assertRenderStatus(InstrumentedTestUtils.kt:31)
        at com.android.designcompose.testapp.validation.AnimationMidpoints.variantAnimation(AnimationMidpoints.kt:74)

@timothyfroehlich
Copy link
Member

Assigning to Ralph for priority

@rylin8 rylin8 added this to the 0.27 milestone Apr 22, 2024
@iamralpht iamralpht added engProd Engineering productivity - build system, testing, etc 🟢 P2 Priority for next 2-3 releases labels May 8, 2024
@iamralpht iamralpht removed this from the 0.27 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engProd Engineering productivity - build system, testing, etc 🟢 P2 Priority for next 2-3 releases
Projects
Status: Needs Triage
Development

No branches or pull requests

3 participants