Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate layout and appearance style properties #869

Open
iamralpht opened this issue Mar 13, 2024 · 3 comments
Open

Separate layout and appearance style properties #869

iamralpht opened this issue Mar 13, 2024 · 3 comments

Comments

@iamralpht
Copy link
Collaborator

The layout and appearance properties are all bundled into ViewStyle -- we can refactor ViewStyle to contain several structs that are more focused on a particular area (ViewStyle is currently modeled after DOM style, but this isn't necessarily the best direction). Additionally, we could choose to break layout down into interior/exterior, or even further along "which properties are used by which layout model".
@iamralpht
Copy link
Collaborator Author

#792 has some discussion on splitting up layout properties.

@iamralpht iamralpht mentioned this issue Mar 13, 2024
Merged
@iamralpht
Copy link
Collaborator Author

Also worth thinking about how tokens fit in, if we revisit ViewStyle.

@rylin8
Copy link
Collaborator

rylin8 commented Apr 23, 2024

@iamralpht did this PR resolve this #974, or is there more to be done with this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
DesignCompose
Status: Needs Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamralpht @rylin8