Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a repository archive for consistent checksum #167

Open
l46kok opened this issue Jan 31, 2023 · 2 comments
Open

Release a repository archive for consistent checksum #167

l46kok opened this issue Jan 31, 2023 · 2 comments
Labels
enhancement New feature or request P3

Comments

@l46kok
Copy link

l46kok commented Jan 31, 2023

Per bazel-contrib/SIG-rules-authors#11, the checksum of repository code download archives (https://github.com/google/bazel-common/archive/_COMMIT_.zip) are not stable.

In fact, the checksum was changed earlier today as seen in the above issue, though that change was rolled back. Please consider releasing an archive under /archive/refs/tags/$tag, which its SHA256 value is promised to be stable.

@chaoren
Copy link
Member

chaoren commented Jan 31, 2023

Maybe we should just use git_repository instead of http_archive in the README? We don't currently do fixed releases here, so I'm not sure we want to start promising them.

@l46kok
Copy link
Author

l46kok commented Jan 31, 2023

git_repository is unideal in many circumstances, since it doesn't support repository caching and it requires downstream users to have git installed (especially problematic for CI / docker container builds). The Bazel team also recommends using http_archive instead.

@chaoren chaoren added enhancement New feature or request P3 labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3
Projects
None yet
Development

No branches or pull requests

2 participants