Ubuntu Vivid Vervet - missing required package (openjdk-8-source) #69
Comments
|
Assigning to kchodorow, although it's a bit strange becayse src.zip is not referenced in jdk.BUILD. Once that strangeness is taken care of (probably my ignorance), all this needs at most is a change in the installation instructions. |
|
if we have a dependency on "bc" we should remove that dependency |
|
How do you do floating point addition in a shell script? The bc dependency comes from the shell test framework. It is used to compute test durations |
|
ugh. we'll have to add bc to the install instructions then. |
|
Do we really need to use Python's time.time()? Why not just use http://stackoverflow.com/questions/16548528/linux-command-to-get-time-in-milliseconds and then $((end-start)) in unittest.bash? |
|
Because it does not work on OSX :( On Wed, Apr 15, 2015 at 4:04 PM Kristina notifications@github.com wrote:
|
|
I mean date does not provide below seconds precision on OSX. On Wed, Apr 15, 2015 at 4:06 PM Damien Martin-guillerez dmarting@google.com
|
|
Okay, but Python does and we could turn the fp date it gives into an int. |
|
Right you mean to get read of the bc operator. SGTM On Wed, Apr 15, 2015 at 4:11 PM Kristina notifications@github.com wrote:
|
|
The bc dependency has been fixed and I don't think we reference src.zip anymore. Feel free to reopen if this is still broken for you. |
|
I ran into the this issue on Debian 8. As suggested in the initial report, installing |
|
I can confirm that Debian 8 also needs the openjdk-8-source package, due to the "src.zip" dependency. Reproduced in a Debian 8.1 64-bit VM. Should we just add that to the docs? |
|
Do we know what's depending on src.zip? We shouldn't need it. |
|
+1 Also apparently we will need the ErrorProne Javac when we will ship Error Prone so we might as well drop the requirements for Java 8 if we do so. |
|
0bf90f7 This commit should have removed the requirement. To be confirmed. |
|
Even with this commit, the issue is still present on Debian 8.1 with openjdk-8-jdk installed, but not openjdk-8-source. Damien and I had a look at it and it looks like Debian ships a broken symlink in the package: root@debian64:/usr/lib/jvm/java-8-openjdk-amd64# ls -l The src.zip symlink goes to ../openjdk-8/src.zip, which doesn't exist (it is part of the openjdk-8-source package). The error message that I'm getting is this: philwo@debian64:~/bazel$ ./compile.sh Maybe we are globbing somewhere in the external repo code and it trips over the broken symlink? |
|
The only glob I see is bin/*, which doesn't have any symlinks on my install (https://github.com/google/bazel/blob/5fe79331f9160ae8b37f907ddbaa5f080dfc8185/src/main/tools/jdk.BUILD and https://github.com/google/bazel/blob/5fe79331f9160ae8b37f907ddbaa5f080dfc8185/src/main/tools/jdk.WORKSPACE are the external repo code). |
damienmg
added
the
P4
|
Yes but there is a reference from //tools/jdk/jdk to /usr/lib/jvm/java-8-openjdk-amd64/src.zip (probably on everything from the java home dir). It is probably under the magic of the local_repository (symlinks?). Anyway I don't think we should try to fix that one right now except fix the documentation. It is a really weird corner case and we have other priorities. |
|
Oh, yeah, maybe here (if anyone wants to work on this). |
This is a dependency due to issue #69. -- MOS_MIGRATED_REVID=96751552
According to bazelbuild/bazel#69, Debian ships a busted symlink in the openjdk-8-jdk package, and installing openjdk-8-source fixes it.
|
Git HEAD doesn't suffer from the dangling "src.zip" symlink although it is still created. This issue can probably be closed now. |
TLDR - "sudo apt-get install openjdk-8-source" fixes it.
EDIT: Should've waited for the whole test, but this one is not so critical: "bc" also needs to be installed for the sh_tests to pass (so one more "apt-get install bc")
Here is the full story (without the "bc" failure):
(utopic)malkia@localhost:~/p/google/bazel$ ./bootstrap_test.sh test
*** bootstrap ***
INFO: Starting clean (this may take a while). Consider using --expunge_async if the clean takes more than several minutes.
ERROR: /home/malkia/p/google/bazel/tools/jdk/BUILD:50:1: error loading package 'external': Could not access /home/malkia/.cache/bazel/_bazel_malkia/25bda5d738c2f595d569ca82f756ade7/.external-repository/local-jdk/src.zip: /usr/lib/jvm/openjdk-8 (No such file or directory) and referenced by '//tools/jdk:jdk'.
ERROR: Loading failed; build aborted.
INFO: Elapsed time: 0.609s
Bootstrap failed
(utopic)malkia@localhost:
/p/google/bazel$ ls -l /home/malkia/.cache/bazel/_bazel_malkia/25bda5d738c2f595d569ca82f756ade7/.external-repository/local-jdk/src.zip/p/google/bazel$ ls -l /usr/lib/jvm/java-8-openjdk-amd64/src.ziplrwxrwxrwx 1 malkia malkia 41 Mar 27 00:36 /home/malkia/.cache/bazel/_bazel_malkia/25bda5d738c2f595d569ca82f756ade7/.external-repository/local-jdk/src.zip -> /usr/lib/jvm/java-8-openjdk-amd64/src.zip
(utopic)malkia@localhost:
lrwxrwxrwx 1 root root 20 Mar 17 19:18 /usr/lib/jvm/java-8-openjdk-amd64/src.zip -> ../openjdk-8/src.zip
(utopic)malkia@localhost:
/p/google/bazel$ ls -l /usr/lib/jvm/openjdk-8/p/google/bazel$ sudo apt-get install openjdk-8-sourcels: cannot access /usr/lib/jvm/openjdk-8: No such file or directory
(utopic)malkia@localhost:
[sudo] password for malkia:
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
openjdk-8-source
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 46.0 MB of archives.
After this operation, 51.8 MB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu/ vivid/universe openjdk-8-source all 8u40-b27-1 [46.0 MB]
Fetched 46.0 MB in 16s (2783 kB/s)
Selecting previously unselected package openjdk-8-source.
(Reading database ... 98820 files and directories currently installed.)
Preparing to unpack .../openjdk-8-source_8u40-b27-1_all.deb ...
Unpacking openjdk-8-source (8u40-b27-1) ...
Setting up openjdk-8-source (8u40-b27-1) ...
(utopic)malkia@localhost:~/p/google/bazel$ ./bootstrap_test.sh test
*** bootstrap ***
INFO: Starting clean (this may take a while). Consider using --expunge_async if the clean takes more than several minutes.
INFO: Found 2 targets...
INFO: From Building src/main/java/libbazel-core.jar (1171 files):
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
INFO: Elapsed time: 97.663s, Critical Path: 92.35s
==> bootstrap passed
Extracting Bazel installation...
Sending SIGTERM to previous Bazel server (pid=6798)... done.
.............
*** test ***
INFO: Found 69 targets and 19 test targets...
[213 / 323] Still waiting for 54 jobs to complete:
Running (standalone):
action 'CompileProtos src/main/protobuf/libproto_build.jar', 10 s
action 'CompileProtos src/main/protobuf/libproto_bundlemerge.jar', 10 s
action 'CompileProtos src/main/protobuf/libproto_crosstool_config.jar', 10 s
action 'CompileProtos src/main/protobuf/libproto_test_status.jar', 10 s
Scheduling:
action 'CompileProtos src/main/protobuf/libproto_xcodegen.jar', 12 s
action 'CompileProtos src/main/protobuf/libproto_extra_actions_base.jar', 12 s
Executing genrule //examples/gen:genrule, 12 s
Building src/java_tools/buildjar/libjava-langtools-location-lib.jar (1 files), 11 s
Building src/java_tools/buildjar/libjavac-bootclasspath-locations-lib.jar (1 files), 11 s
Extracting interface //third_party:truth, 11 s
Linking src/main/cpp/libmd5.so, 11 s
Building src/main/java/libjava-toolchain-parser.jar (11 files), 11 s
Linking src/main/cpp/libutil.so, 11 s
... 41 more jobs
The text was updated successfully, but these errors were encountered: