Skip to content
This repository has been archived by the owner on Dec 10, 2022. It is now read-only.

Replace BlockEditorView.show(blockDef) #304

Open
AnmAtAnm opened this issue Mar 12, 2018 · 1 comment
Open

Replace BlockEditorView.show(blockDef) #304

AnmAtAnm opened this issue Mar 12, 2018 · 1 comment
Assignees
@AnmAtAnm
Labels
component: navigation type: code cleanup
Projects
2019 Release

Comments

@AnmAtAnm
Copy link
Contributor

BlockEditorView.show(blockDef) duplicates code/functionality in .showBlock(blockDef), and does edit "tab" manipulation without involving the AppController.

Replace the function with a call in AppController that calls (directly or indirectly) BlockEditorView.showBlock(blockDef).
@AnmAtAnm AnmAtAnm self-assigned this Mar 12, 2018
@AnmAtAnm
Copy link
Contributor Author

The different code paths through BlockEditorView.show(blockDef) and .showBlock(blockDef) is probably partially responsible for #297.

@AnmAtAnm AnmAtAnm added this to Nice To Have in 2019 Release Nov 30, 2018
@AnmAtAnm AnmAtAnm added this to Nice To Have in 2019 Release Dec 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AnmAtAnm AnmAtAnm

Labels
component: navigation type: code cleanup
Projects
No open projects
2019 Release
  
Nice To Have
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AnmAtAnm