Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dispose method to workspace search #117

Closed
alschmiedt opened this issue Mar 11, 2020 · 0 comments · Fixed by #118
Closed

Add dispose method to workspace search #117

alschmiedt opened this issue Mar 11, 2020 · 0 comments · Fixed by #118
Assignees
@alschmiedt

Comments

@alschmiedt
Copy link
Contributor

alschmiedt commented Mar 11, 2020 •
edited

Questions from PR:
Should this also call workspace_.dispose as workspace search is usually wrapped around a workspace.
Need to dispose of event handlers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alschmiedt alschmiedt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dispose method to workspace search alschmiedt/blockly-samples
1 participant
@alschmiedt