Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Action that runs the formatter #1977

Closed
1 task done
maribethb opened this issue Sep 26, 2023 · 1 comment · Fixed by #2060
Closed
1 task done

Add a GitHub Action that runs the formatter #1977

maribethb opened this issue Sep 26, 2023 · 1 comment · Fixed by #2060
Assignees
Labels
good first issue Good for newcomers type: feature request New feature or request

Comments

@maribethb
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

entire repo

Problem

No response

Request

After #1946 is submitted, we'll have a new top-level script that can automatically format the entire repository. On every pull request, we should run npm run format:check which will run the formatter in a mode that reports if any file needs formatting still. We have a similar action in core blockly here. We should add a similar job to our existing build/lint action in blockly-samples.

Alternatives considered

No response

Additional context

No response

@maribethb maribethb added type: feature request New feature or request triage labels Sep 26, 2023
@maribethb maribethb added good first issue Good for newcomers and removed triage labels Sep 27, 2023
@sdthaker
Copy link
Contributor

sdthaker commented Nov 4, 2023

Hi there! Can you please assign this to me? I'd like to work on this issue. Currently working on # 1978, will get to this one once I'm done with that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature request New feature or request
Projects
None yet
2 participants