Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the jsdoc/tag-lines eslint rule #1979

Closed
1 task done
maribethb opened this issue Sep 26, 2023 · 6 comments · Fixed by #2066
Closed
1 task done

Re-enable the jsdoc/tag-lines eslint rule #1979

maribethb opened this issue Sep 26, 2023 · 6 comments · Fixed by #2066
Assignees
Labels
good first issue Good for newcomers type: feature request New feature or request

Comments

@maribethb
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

all

Problem

In #1946, we adjusted the way linting works in the repo and had to disable some rules. One of them is the jsdoc/tag-lines rule, which controls how many empty lines should be present between the description paragraph and any tags present.

In the eslint.config.js file, find the commented out line for jsdoc/tag-lines in the section of rules that applies to TypeScript file. Uncomment the line and remove the TODO comment.

Request

To close this issue:

  • Wait for chore: add formatting with prettier #1946 to be submitted
  • In the eslint.config.js file, find the commented out line for jsdoc/tag-lines in the section of rules that applies to TypeScript file. Uncomment the line and remove the TODO comment.
  • Run npm run lint:fix from the root of blockly-samples to automatically fix all of the issues related to this eslint rule
  • Open a PR with the changes

Alternatives considered

No response

Additional context

No response

@maribethb maribethb added type: feature request New feature or request triage labels Sep 26, 2023
@maribethb maribethb added good first issue Good for newcomers and removed triage labels Sep 27, 2023
@jaas666
Copy link

jaas666 commented Oct 13, 2023

I can help with this if needed once #1946 gets merged

@barkhaaroraa
Copy link
Contributor

could i work on this?

@BeksOmega
Copy link
Contributor

@jaas666 were you still interested in working on this?

@jaas666
Copy link

jaas666 commented Oct 30, 2023

Sorry, no bandwidth at the moment.
You can assign to @barkhaaroraa

@sdthaker
Copy link
Contributor

sdthaker commented Nov 7, 2023

Let me know if this is still up for grabs, might be related to #1978, since running npm run lint:fix shows 16 warnings in total which I'm fixing in 1978. Would like to work on this issue! Thanks!

@BeksOmega
Copy link
Contributor

Done @sdthaker ! I'll get you feedback on your other PRs/issues this morning =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature request New feature or request
Projects
None yet
5 participants