You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Since we have started using Clang format we have started to run into places where eslint and clang rules do not match up.
Describe the solution you'd like
According to this comment it seems like eslint and clang format do not always play nice when it comes to indenting. The best way to deal with this seems to be to turn off eslint indentation rules, and then add some check to make sure that the files are formatted correctly using clang. Something like this github action might come in handy.
Describe alternatives you've considered
A developer can run clang format and then eslint --fix. This doesn't work great when a developer is formatting every time they save a file. It also means a developer has to remember to do this every time before they commit.
We can try to update eslint indentation rules to match clang as we go. This seems like a lot of work and like it would be difficult to get this a hundred percent correct.
Additional context
Once we come up with a solution we like, we should move it over to core.
The text was updated successfully, but these errors were encountered:
In core we fixed this problem by removing the indentation rules for eslint. I am assuming we are going to do this here as well, so removing this issue in favor of #962.
Category
Release
Component
Is your feature request related to a problem? Please describe.
Since we have started using Clang format we have started to run into places where eslint and clang rules do not match up.
Describe the solution you'd like
According to this comment it seems like eslint and clang format do not always play nice when it comes to indenting. The best way to deal with this seems to be to turn off eslint indentation rules, and then add some check to make sure that the files are formatted correctly using clang. Something like this github action might come in handy.
Describe alternatives you've considered
Additional context
Once we come up with a solution we like, we should move it over to core.
The text was updated successfully, but these errors were encountered: