Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Renderer does not work with Dec 2021 release #944

Closed
alschmiedt opened this issue Dec 2, 2021 · 1 comment
Closed

Debug Renderer does not work with Dec 2021 release #944

alschmiedt opened this issue Dec 2, 2021 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@alschmiedt
Copy link
Contributor

Category
Plugins

Component
dev-tools
debugRenderer

Describe the bug
The debug renderer does not work with the December 2021 release of Blockly. I believe this is because this line is no longer allowed since Blockly.blockRendering is sealed.

To Reproduce

Steps to reproduce the behavior:

  1. Run dev-tools with the most recent release of Blockly
  2. Drag out a block
  3. Notice how all blocks have all of the debug information on them despite not all the boxes in the debug tab have been selected.

Expected behavior
The debug renderer should only display the desired debug information.
It should also use the debug renderer that is in samples. I believe right now it is using the one that is still in core.

Screenshots

Additional context
Talked with Rachel about this and the move here might be to add the debug renderer to the registry and to finish moving the default debug renderer from core into samples.

@alschmiedt
Copy link
Contributor Author

Fixed in #945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant