Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout getMetrics causes a reflow and style recalculation #1303

Closed
picklesrus opened this issue Sep 1, 2017 · 1 comment
Closed

Flyout getMetrics causes a reflow and style recalculation #1303

picklesrus opened this issue Sep 1, 2017 · 1 comment
Assignees
@picklesrus
Labels
component: performance component: toolbox/flyout

Comments

@picklesrus
Copy link
Contributor

Very similar issue to what a67f841 solved.

Extra considerations for the flyout:

  • Flyout also contains labels and buttons which need to be added to the bounding box calculations.
  • Gaps as specified by the toolbox/flyout xml.
@picklesrus picklesrus self-assigned this Sep 1, 2017
@picklesrus picklesrus mentioned this issue Sep 1, 2017
Closed
@alschmiedt
Copy link
Contributor

The flyout now stores its width and height every time reflow is called. The metrics manager uses these values every time we call getMetrics instead of calling getBBox on the html div.

This was referenced Jul 9, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picklesrus picklesrus

Labels
component: performance component: toolbox/flyout
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RoboErikG @picklesrus @alschmiedt