Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Dart 2.0 #1951

Closed
rachel-fenichel opened this issue Jun 27, 2018 · 3 comments
Closed

Upgrade to Dart 2.0 #1951

rachel-fenichel opened this issue Jun 27, 2018 · 3 comments
Labels
component: generators component: tests help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added low priority

Comments

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Jun 27, 2018

Problem statement

Dart has upgraded to 2.0, and so has the page we use for testing (dartpad). Some of our generators don't work in 2.0 because there are breaking changes in the language. We need to upgrade, ideally before the release at the start of September.

Expected Behavior

Generated code from the generator tests in Dart can run on DartPad.

Actual Behavior

A variety of type errors.

Steps to Reproduce

Load all tests in the generator test page, and run the generated Dart in DartPad.

Instructions for testing generators: https://developers.google.com/blockly/guides/modify/web/unit-testing#block_generator_tests

@rachel-fenichel rachel-fenichel added low priority issue: feature request Describes a new feature and why it should be added component: generators component: tests help wanted External contributions actively solicited labels Jun 27, 2018
@AnmAtAnm
Copy link
Contributor

Assuming there is not a form that is compatible with both 1 and 2, do we need to keep a copy of the Dart 1 generator around for older existing projects? I don't mind deprecating it and taking it out of testing (or test generation without running the resulting code).

Alternatively, we can just point people to the older repo.

@rachel-fenichel
Copy link
Collaborator Author

I think we should just upgrade and tell people to go back in time to get the older generator.

@rachel-fenichel
Copy link
Collaborator Author

Done (thanks Neil)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: generators component: tests help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added low priority
Projects
None yet
Development

No branches or pull requests

2 participants