-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package name casing inconsistencies #2102
Comments
To clarify, a name should start with lowercase if it is just a namespace, but should start uppercase if it is a constructor. Thus In our case A list of currently incorrect names in core are:
Not sure if there are any here that can be easily renamed without breaking 3rd party stuff. |
After discussion with the team, the only item on this list we felt comfortable changing was Blockly.BlockAnimations > Blockly.blockAnimations. The rest failed the cost-benefit analysis. |
For the record:
Closing issue. |
The
Blockly
namespace is capitalized.The
Blockly.Xml
namespace is also capitalized.The
Blockly.utils
andBlockly.Xml.utils
used a mix of capitalized and lowercase.Google Style Guide recommends
lowerCamelCase
for each part of a package name.(The likelihood of fixing these are probably zero, due to backward compatibility needs. Still, it is worth highlighting to prevent further inconsistencies.)
The text was updated successfully, but these errors were encountered: