Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments should be allowed on non-movable/deletable blocks #2388

Closed
RoboErikG opened this issue Apr 17, 2019 · 1 comment
Closed

Comments should be allowed on non-movable/deletable blocks #2388

RoboErikG opened this issue Apr 17, 2019 · 1 comment
Labels
help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added

Comments

@RoboErikG
Copy link
Contributor

Problem statement

Currently, the check for whether or not you can add a comment to a block includes checking that a block can be moved and deleted. Comments should probably be allowed in the cases that a block is not movable or not deletable so long as it is still editable.

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. Start by..
  2. Next, do..

Stack Traces

Replace with error stack trace.

Operating System and Browser

Additional Information
@RoboErikG RoboErikG added help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added labels Apr 17, 2019
@ahigerd ahigerd mentioned this issue Apr 18, 2019
Merged
3 tasks
@ahigerd
Copy link
Contributor

ahigerd commented Apr 18, 2019

I believe the above PR ought to address this issue.

@rachel-fenichel rachel-fenichel mentioned this issue Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahigerd @RoboErikG