Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIT's licence appearing in compressed file #2412

Closed
NeilFraser opened this issue Apr 26, 2019 · 2 comments
Closed

MIT's licence appearing in compressed file #2412

NeilFraser opened this issue Apr 26, 2019 · 2 comments
Assignees

Comments

@NeilFraser
Copy link
Contributor

The Closure compiler leaves all licences in the compiled code, presumably for legal reasons. This resulted in dozens of copies of Google's standard licence in the compressed JS files. To fix this, there's a regular expression that detects Google's standard Apache licences and strips them:
https://github.com/google/blockly/blob/master/build.py#L394

However, there's now an MIT licence that's lurking in the compressed file:
https://github.com/google/blockly/blob/master/blockly_compressed.js#L1579

This represents 634 bytes that do nothing. The source is here:
https://github.com/google/blockly/blob/master/core/dropdowndiv.js

Can we get written permission from MIT that it's ok to strip their licence in compiled code only? No change to their source code or to their licence.

@thisandagain
Copy link

Hi @NeilFraser. Yes, it is ok to strip the MIT License from the compiled code.

@NeilFraser NeilFraser self-assigned this Apr 29, 2019
@NeilFraser
Copy link
Contributor Author

Resolved in Blockly with 8d4a73e

Resolved in Blockly Games with google/blockly-games@88d59e1

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants