Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hideChaff doesn't cancel chaff that's animating open #2555

Closed
NeilFraser opened this issue Jun 8, 2019 · 1 comment
Closed

hideChaff doesn't cancel chaff that's animating open #2555

NeilFraser opened this issue Jun 8, 2019 · 1 comment
Labels
issue: bug Describes why the code or behaviour is wrong type: regression
Milestone
2019_q2_release

Comments

@NeilFraser
Copy link
Contributor

If a colour-picker is open, calling hideChaff closes it. Good.

But if a colour-picker is doing its opening animation, hideChaff fails to cancel the opening. The result is the following screenshot from Blockly Games. When the dialog opens it calls hideChaff, but as can be seen, the colour-picker was not closed.

Screen Shot 2019-06-07 at 23 15 59
@rachel-fenichel rachel-fenichel added this to the 2019_q2_release milestone Jun 10, 2019
@rachel-fenichel rachel-fenichel added the issue: bug Describes why the code or behaviour is wrong label Jun 10, 2019
@NeilFraser
Copy link
Contributor Author

Fixed by #2551.

@rachel-fenichel rachel-fenichel mentioned this issue Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Describes why the code or behaviour is wrong type: regression
Projects
None yet
Milestone
2019_q2_release
Development

No branches or pull requests
2 participants
@NeilFraser @rachel-fenichel