Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function argument names not escaped #2624

Closed
NeilFraser opened this issue Jul 9, 2019 · 1 comment
Closed

Function argument names not escaped #2624

NeilFraser opened this issue Jul 9, 2019 · 1 comment

Comments

@NeilFraser
Copy link
Contributor

blocks/procedures.js line 175 is vulnerable to injection:

          '  <field name="NAME">' + this.arguments_[i] + '</field>' +

Create a function argument called <>, close the mutator, and reopen the mutator. Mutator crashes.

@BeksOmega In general, this is why XML (and HTML) should be built up node by node, rather than as dynamically-generated strings (with a comment above to show what the goal XML should be, since node building is not easily legible).

@NeilFraser
Copy link
Contributor Author

Thanks for the quick patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants