Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for publishing blockly-demo to app engine #3209

Closed
samelhusseini opened this issue Oct 9, 2019 · 5 comments
Closed

Script for publishing blockly-demo to app engine #3209

samelhusseini opened this issue Oct 9, 2019 · 5 comments
Labels
component: build process internal External contributions not accepted issue: feature request Describes a new feature and why it should be added

Comments

@samelhusseini
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Script for publishing blockly-demo to app engine

Describe the solution you'd like

With gcloud being an npm package: https://www.npmjs.com/package/gcloud, we can add it as a dev dependency and have a deploy script that deploys the app to appengine.

Additional context

@samelhusseini samelhusseini added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member component: build process internal External contributions not accepted and removed issue: triage Issues awaiting triage by a Blockly team member labels Oct 9, 2019
@NeilFraser
Copy link
Contributor

Currently one just pushes the "Deploy" button in GoogleAppEngineLauncher. This way it's not an option that external developers end up with. Not sure what problem we're trying to solve here.

@rachel-fenichel
Copy link
Collaborator

The problem we're solving for is that we have a lot of manual steps for deployment. Each one is pretty simple, but it would be better to tie them all together into a script.

As a bonus, I believe the google app engine launcher is both deprecated and doesn't work on linux.

@samelhusseini I'm also down to have this in a separate repo with the rest of our tooling, though that seems unnecessary.

@RoboErikG
Copy link
Contributor

Any issue with putting it in blockly-tools?

@rachel-fenichel
Copy link
Collaborator

Mostly that the rest of our releasing stuff is over here (in the scripts section in package.json), and we've been moving toward being able to just say npm run release. Pulling in blockly-tooling and linking everything adds complexity and seems nonstandard.

@moniika
Copy link
Contributor

moniika commented Mar 29, 2021

Fixed in #4551
with the caveat that the npm package gcloud is deprecated and so gcloud needs to be manually set up at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build process internal External contributions not accepted issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

No branches or pull requests

5 participants