Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zelos rendering] vertical tight nesting #3495

Closed
samelhusseini opened this issue Dec 7, 2019 · 2 comments
Closed

[zelos rendering] vertical tight nesting #3495

samelhusseini opened this issue Dec 7, 2019 · 2 comments
Labels
component: rendering issue: feature request Describes a new feature and why it should be added

Comments

@samelhusseini
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Similar to how we cut back the implicit padding added by the left and right connection shapes, we need to do the same with the padding added by the top / bottom row in some situations:

Screen Shot 2019-12-06 at 4 48 28 PM

Describe the solution you'd like

Use negative spacing on the first and last row spacer.

@samelhusseini samelhusseini added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member component: rendering and removed issue: triage Issues awaiting triage by a Blockly team member labels Dec 7, 2019
@samelhusseini
Copy link
Contributor Author

Done.

@laurensvalk
Copy link
Contributor

I realize this is an older issue, but I'm really curious about the design reason behind this fix.

Until I found this thread, I somehow assumed this was a glitch/bug. It seemed surprising that the block would get vertically smaller when inserting a block, with the whole stack resizing as a result.

Maybe this is less noticeable in Blockly apps that don't use many shadow inputs?

resizeshadow.mp4

Video can be reproduced on the advanced playground with Zelos renderer and theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: rendering issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

No branches or pull requests

2 participants