-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Public Metrics Method #3746
Comments
So far it seems like the following methods would be most useful: getAbsoluteMetrics (or different name) Gets the metrics for the workspace without the toolbox. getContentMetrics (probably different name. I don't like this name.) This would hold what is currently the content and view metrics from our current getMetrics method. getToolboxMetrics Contain the metrics for both the flyout and toolbox |
Related concerns:
|
Another use case would be preventing blocks from going behind an always-open flyout (more specifically, a flyout on a toolbox where the flyout has autoClose = true. This already works when the workspace contains just a flyout and no toolbox). Currently to achieve this, most of getTopLevelWorkspaceMetrics is fine, but we need to change some properties to take into account the width of both toolbox + flyout. So having this method public would allow me to call it from a custom getMetrics method without having to copy/paste a bunch of code I don't need to change. The approach of having multiple smaller public methods also seems like it could work, I could call those methods for the values I don't need to change, and put their values into my custom getMetrics method. |
Is your feature request related to a problem? Please describe.
Currently the only way to get metrics is by using the same method we use internally for processes that need to know just about everything about the workspace. Therefore, the method returns a lot of information that is not well organized or very well documented.
Describe the solution you'd like
A metrics method that is meant to be public and provides a subset of the current values returned from getMetrics with easier to understand and better documented values.
Describe alternatives you've considered
Additional context
Possible Use Cases:
The text was updated successfully, but these errors were encountered: