Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External images not working on dropdown input #4015

Closed
fabiooliveira1 opened this issue Jul 6, 2020 · 2 comments
Closed

External images not working on dropdown input #4015

fabiooliveira1 opened this issue Jul 6, 2020 · 2 comments
Labels
component: fields issue: bug Describes why the code or behaviour is wrong type: regression
Milestone
2020_q3_release

Comments

@fabiooliveira1
Copy link

Describe the bug

Images from external sources are not being displayed on dropdown options on production environment - neither on my project nor on blockly demos.
Instead of displaying it, a message object HTMLImageElement is shown.

To Reproduce

Steps to reproduce the behavior:
Click here: demo

or

  1. Go to https://blockly-demo.appspot.com/static/demos/blockfactory/index.html
  2. Add a dummy input inside the main block
  3. Add a dropdown field inside the dummy input
  4. Change the dropdown items to show only one image - instead of 3 text field
  5. Click on dropdown options on the preview
  6. See the message [object HTMLImageElement] instead of showing the image

Expected behavior

It was supposed to show a image on the dropdown options

Screenshots

image

Desktop:

  • OS: Ubuntu 19.04
  • Browser: Chrome
  • Version: 83.0.4103.106 (Official Build) (64-bit)

Additional context

It works on local environment
@fabiooliveira1 fabiooliveira1 added issue: triage Issues awaiting triage by a Blockly team member issue: bug Describes why the code or behaviour is wrong labels Jul 6, 2020
@moniika moniika added type: regression component: fields and removed issue: triage Issues awaiting triage by a Blockly team member labels Jul 6, 2020
@moniika moniika added this to the 2020_q3_release milestone Jul 6, 2020
@samelhusseini
Copy link
Contributor

A git bisect leads to this PR: #3880

@samelhusseini samelhusseini mentioned this issue Jul 6, 2020
Merged
3 tasks
@samelhusseini
Copy link
Contributor

Fixed and released patch 3.20200625.2

@samelhusseini samelhusseini mentioned this issue Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: fields issue: bug Describes why the code or behaviour is wrong type: regression
Projects
None yet
Milestone
2020_q3_release
Development

No branches or pull requests
3 participants
@moniika @fabiooliveira1 @samelhusseini