-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Message String...
warning in console
#4369
Comments
I think this is the same issue that is happening in #4358. I will close that one in favor of easier repro steps described here. Based on investigation on that issue already done by @oleggo, Line 415 in 11987dc
|
@moniika it happens in the case when Blockly main module starts to load AFTER Line 486 in 11987dc
One possible scenario is when Blockly is loaded under Webpack. |
Has this issue been fixed? I am still able to recover this error. Is there a recommended solution? Desktop (please complete the following information): |
I'm also interested in this issue. It started to appear when I split my React app using code splitting. Here's the relevant discussion on Google Groups: https://groups.google.com/g/blockly/c/VQ1qjKMe3m4/m/Z-s_T2vrEQAJ |
I am also facing this issue. Does anyone know how to fix this? |
Also having the issue. I'm using lazy loading with:
|
@stnor That seems consistent with the problem I'm having. Although these warnings are annoying, they haven't been a problem for my app so far. |
It also causes "screenshader.js:80 Uncaught Error: Tooltip function must return a string" I don't do anything special, just load html with a simple Blockly example. Getting lots of warnings. [EDIT] Just noticed, all warning I'm getting are about TOOLTIP. if it helps...
|
Hello all! Sadly I'm not sure that this is something the core team can fix on our end :/ The issue is that Blockly's translation files need to be loaded before Blockly is loaded, which (as far as I can tell) is related to how Blockly gets webpacked/rolledup along with the rest of an application. If you run into this issue, the only thing I can recommend (at the moment) is digging into how your architecture handles loading, to make sure that message files get loaded before the rest of Blockly. If anyone has information about how the core team could ensure this from our end, we would love more information =) |
I'm using Create React App, which does the loading using its pre-configured webpack settings. Create React App is pretty popular, so I imagine this will be a common problem with Blockly. That said, these warnings haven't been a problem other than the annoying console messages, so it's something I'm willing to live with. |
But if you hover the mouse over the blocks - when it tries to display the Tooltip - doesn't it fail because the messages are not loaded? |
@alexbk66 Is this the tooltip you're referring to? Seems to work for me: |
Hi everyone, We submitted a fix for a related issue and I'm hoping it may have helped this, but since we don't use Angular or React ourselves it would be great to hear from you. Could you try this beta version |
Hello, I just recently started a project using Blockly in Angular and was running into this issue when using version 8.0.0 but updating to the version 8.0.1-beta.0 was able to fix the problem. However when updating to version 8.0.1 that just released the problem returned so I had to go back to the beta version. Was the fix intentionally removed in the stable release for 8.0.1 and if so can we expect it in a future stable release? |
Thanks for confirming that the beta patch fixed the issue in Angular! We hadn't been able to confirm that before so that is great to hear. Unfortunately the patch we applied to fix it for this case broke using |
I am having this issue as well without a build step. I did
Unfortunately I'm not able to find the beta branch or release package to test if that would fix it. If I move
|
I use version 8.0.2 too. |
@BeksOmega I tried This error doesn't occur in I hope that's helpful. |
Thanks Johnny. We have the latest fix at |
@maribethb I just tried 8.0.4-beta.1 and unfortunately I still get the string warnings: My environment is described here: https://groups.google.com/g/blockly/c/VQ1qjKMe3m4/m/DmoPBv7RDgAJ If it'll be helpful, I can create a simple React repo with code splitting to reproduce the warnings. |
I have reverted Blawx to github's v8.0.2 and created a local copy of the 8.0.4 version of the en.js file, and loaded it as suggested above by @adrianfung and @jasonpanelli. That seems to be working. |
Hey all, I've been using Downgrading to 8.0.3 fixes this for me: I've tried specifying 8.0.4-beta.1, but the issue still persists in that version. I recommend bundling a specific version in your app :) |
@Insood can you provide more information? How did 8.0.4 break for you and how are you loading the message files? In particular if you were using one of the workarounds listed here where you used an older version of the |
Just as follow up, #6329 seems to have solved the problem for me. If I remove the workaround, and clone from the "develop" branch of the repository, it seems to be resolved. |
Thanks for confirming! I believe most of the recent comments on this thread were really about #6123 and have accordingly marked that issue as closed. Unfortunately that issue looked similar in effect to this one, but I've confirmed the original issue reported here is still occurring, as it relates to React specifically or perhaps lazy loading in general, so I'm going to leave this one open. In particular with this issue you'll get warnings in the console but everything will actually work as expected. If anyone else reading this experiences a similar issue but things don't work as expected (in other words, you get these console warnings AND blocks/toolboxes actually appear broken) please open a new issue as that would not be related to this one. Thank you! |
This creates a lot of garbage in our unit tests logs.
I found we only needed to do this once in our entry point. |
This seems to be a general issue with lazy loading, as I am experiencing the same thing when lazy loading Blockly in a Vue 3 app. |
Can this be resolved for real? I appreciate the purpose of these messages for developers, but it doesn't make sense to have them for end users. |
M.b. introduce a flag do not show such errors when compile for prod mode? |
@cpcallen this now happens in the playground, after your recent change to bootstrapping/loading. Did you expect that? |
Describe the bug
In a minimal Blockly use case with a simple toolbox, warnings of the following type appear in the console:
To Reproduce
Expected behavior
No warnings in the console
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: