Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break/continue block does not react to movements of the parent block #4500

Closed
BeksOmega opened this issue Dec 5, 2020 · 2 comments
Closed
Assignees
Labels
component: library blocks issue: bug Describes why the code or behaviour is wrong type: regression

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Dec 5, 2020

Describe the bug

When you move the parent of a break/continue block, the block does not check if it is now inside/outside of a loop:
BreakBlock

Note: This repros on master.

To Reproduce

Steps to reproduce the behavior:

  1. Add the break block, a loop block, and another block with a statement connection (eg controls_if) to your workspace.
  2. Nest all of them together, with the loop block as the outer block.
  3. Move the statement connection block inside and outside of the loop.
  4. Observe how the break/continue block does not update.

Expected behavior

The break/continue block should update whenever it moves inside/outside of a loop.

Additional information
[EDIT: The same thing does not apply to the if-return block:]
ReturnBlock

@BeksOmega BeksOmega added issue: triage Issues awaiting triage by a Blockly team member issue: bug Describes why the code or behaviour is wrong labels Dec 5, 2020
@alschmiedt
Copy link
Contributor

Thanks for reporting!
It looks like the problem is with this check. Since the parent block is the one getting dragged this part is failing.

@alschmiedt alschmiedt added component: library blocks type: regression and removed issue: triage Issues awaiting triage by a Blockly team member labels Dec 7, 2020
@alschmiedt alschmiedt added this to the 2020_q4_release milestone Dec 7, 2020
@maribethb maribethb self-assigned this Dec 9, 2020
@maribethb
Copy link
Contributor

Fixed by #4533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: library blocks issue: bug Describes why the code or behaviour is wrong type: regression
Projects
None yet
Development

No branches or pull requests

3 participants