Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbox and flyout metrics should report appropriate height and width #4594

Closed
alschmiedt opened this issue Jan 15, 2021 · 0 comments
Closed
Labels
issue: feature request Describes a new feature and why it should be added

Comments

@alschmiedt
Copy link
Contributor

Is your feature request related to a problem? Please describe.
getMetrics returns the following information for a flyout and a toolbox:

  • flyoutWidth,
  • flyoutHeight,
  • toolboxWidth,
  • toolboxHeight,

When there is a vertical toolbox or flyout the height is equal to 0. Similarly, when there is a horizontal toolbox or flyout the width is equal to 0.

Describe the solution you'd like
For the toolbox and flyout metrics to accurately report the actual height and width of the flyout.

Describe alternatives you've considered
Keep it as is and continue to return 0.

Additional context
This would mostly include looking into where this value is being used and making sure we don't break anything by updating this.
I don't think this would break a lot of people, but it is worth it to note that this is an api change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

No branches or pull requests

1 participant