Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use captureWarning helper from dev-tools #4761

Closed
moniika opened this issue Apr 6, 2021 · 0 comments
Closed

Use captureWarning helper from dev-tools #4761

moniika opened this issue Apr 6, 2021 · 0 comments
Assignees
@gonfunko
Labels
component: tests help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added type: cleanup
Milestone
Bug Bash Backlog

Comments

@moniika
Copy link
Contributor

moniika commented Apr 6, 2021 •
edited

captureWarnings is now available available on on testHelpers from dev-tools after google/blockly-samples#567.

The captureWarnings definition in mocha/tests/test_helpers.js should be removed and the usages of captureWarnings in the tests under mocha/tests/ should use the captureWarnings function defined on testHelpers from dev-tools.
@moniika moniika added help wanted External contributions actively solicited type: cleanup issue: feature request Describes a new feature and why it should be added component: tests labels Apr 6, 2021
@moniika moniika added this to the Bug Bash Backlog milestone Apr 6, 2021
@gonfunko gonfunko self-assigned this Jun 15, 2021
@gonfunko gonfunko mentioned this issue Jun 15, 2021
Merged
3 tasks
This was referenced Jul 9, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gonfunko gonfunko

Labels
component: tests help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added type: cleanup
Projects
None yet
Milestone
Bug Bash Backlog
Development

No branches or pull requests
2 participants
@gonfunko @moniika