Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hook for getting id of component registered on ComponentManager #4881

Closed
moniika opened this issue Jun 8, 2021 · 1 comment
Closed

Add hook for getting id of component registered on ComponentManager #4881

moniika opened this issue Jun 8, 2021 · 1 comment
Labels
issue: feature request Describes a new feature and why it should be added
Milestone
2021_q2_release

Comments

@moniika
Copy link
Contributor

moniika commented Jun 8, 2021

Is your feature request related to a problem? Please describe.
We need a way to easily get the id of a component so that it can be used for things like addCapability, removeCapabiltiy, and hasCapability on the ComponentManager

Describe the solution you'd like

A property on the interface IComponent.

Describe alternatives you've considered

A method on ComponentManager that returns the id of a component that is passed in as a parameter that searches all registered components.

Additional context
@moniika moniika added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member and removed issue: triage Issues awaiting triage by a Blockly team member labels Jun 8, 2021
@moniika moniika added this to the 2021_q2_release milestone Jun 9, 2021
@moniika moniika mentioned this issue Jun 10, 2021
Merged
3 tasks
@moniika
Copy link
Contributor Author

moniika commented Jun 16, 2021

Fixed in #4887

@moniika moniika closed this as completed Jun 16, 2021
This was referenced Jul 9, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
2021_q2_release
Development

No branches or pull requests
1 participant
@moniika