fix: provide initial values to reduce functions in generated js #6178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
#6169
Proposed Changes
Generated code using reduce (average and sum) has initial value set to 0
Behavior Before Change
Runtime error when calling average or sum on an empty list in javascript
Behavior After Change
No runtime error
Reason for Changes
Reduce without an initial value takes the 1st element in the array as the initial value in javascript -> needs an initial value for empty lists.
Note
Test Coverage
Adjusted existing tests to new generated code
Documentation
Additional Information