Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: options parser should add trailing slash to 'media' if not present. (#6263) #6264

Merged
merged 2 commits into from
Jul 12, 2022
Merged

fix: options parser should add trailing slash to 'media' if not present. (#6263) #6264

merged 2 commits into from
Jul 12, 2022

Conversation

derwehr
Copy link
Contributor

@derwehr derwehr commented Jul 12, 2022 •
edited

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

#6263

Proposed Changes

Add a trailing slash to media option, if not present.
Add deprecated warning to path option

Additional Information

I was unsure about the deletion date on the deprecation warning, so I just set it to 1 year from now.

@derwehr derwehr requested a review from a team as a code owner July 12, 2022 18:10
@derwehr derwehr requested a review from NeilFraser July 12, 2022 18:10
@BeksOmega BeksOmega requested review from BeksOmega and removed request for NeilFraser July 12, 2022 20:38
@BeksOmega BeksOmega assigned BeksOmega and unassigned NeilFraser Jul 12, 2022
BeksOmega
BeksOmega approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for the fix :D

@BeksOmega BeksOmega merged commit bf1a40c into google:develop Jul 12, 2022
@release-please release-please bot mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derwehr @BeksOmega @NeilFraser