Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block missalignment when warning is added during drag #75

Closed
carlosperate opened this issue Feb 25, 2015 · 1 comment
Closed

Block missalignment when warning is added during drag #75

carlosperate opened this issue Feb 25, 2015 · 1 comment

Comments

@carlosperate
Copy link
Contributor

Hi,

When blocks are being drag and a warning is added to any of the blocks (therefore adding the warning icon), the blocks svg misaligns until they are reattached one by one.

As demo I have recorded this quick video of my fork, as I was not quite sure how to replicate the problem with normal blockly:
https://www.youtube.com/watch?v=csbsCaaR_So

@carlosperate carlosperate changed the title Block missalignment when warning is adding during drag Block missalignment when warning is added during drag Feb 25, 2015
@NeilFraser
Copy link
Member

Fixed. Having warning icons appear during a drag is not really helpful (since one can't open them to see the error at that time, and the warning may be resolved by the time the block drops). Blockly now postpones changes to warnings until the block is dropped. This solves the rendering problems too.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants