Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memmove16 implementation is playing with fire #159

Closed
rygorous opened this issue Sep 22, 2015 · 1 comment
Closed

memmove16 implementation is playing with fire #159

rygorous opened this issue Sep 22, 2015 · 1 comment

Comments

@rygorous
Copy link

As already noted in the code https://github.com/google/brotli/blob/master/dec/decode.c#L89, assuming details about the memcpy implementation and optimizations is playing with fire. Maybe introduce a BROTLI_NO_DANGEROUS_OPTIMIZATIONS #define that avoids this kind of code path, to ease porting to non-mainstream architectures?

@eustas
Copy link
Collaborator

eustas commented Sep 28, 2015

Fixed with PR 183.
Compiling with -DBROTLI_BUILD_PORTABLE avoids overlapping memcpy and unaligned reads.

@eustas eustas closed this as completed Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants