Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompress segfaults on Solaris Sparc #204

Closed
jeroen opened this issue Oct 4, 2015 · 4 comments
Closed

Decompress segfaults on Solaris Sparc #204

jeroen opened this issue Oct 4, 2015 · 4 comments

Comments

@jeroen
Copy link

jeroen commented Oct 4, 2015

Possibly related to #203

> brotli_decompress(y)

 *** caught bus error ***
address ffbfc093, cause 'invalid alignment'

Traceback:
 1: .Call(R_brotli_decompress, buf)
 2: brotli_decompress(y)
@eustas
Copy link
Collaborator

eustas commented Oct 4, 2015

Try to compile with -DBROTLI_BUILD_PORTABLE option.

@jeroen
Copy link
Author

jeroen commented Oct 4, 2015

This indeed seems to help. Does this flag have any side effects? Why is it not the default?

@eustas
Copy link
Collaborator

eustas commented Oct 4, 2015

We haven't taken Sparc CPUs into account.
I'll prepare patch that disables unaligned reads on Sparc CPUs.

@eustas
Copy link
Collaborator

eustas commented Oct 6, 2015

Now SPARC and ARMv6 build in "portable" mode by default.

We're going to replace black-listing with white-listing, so unrecognized architectures would be built in "portable" mode.

Thank you for pointing the problem out.

@eustas eustas closed this as completed Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants