Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotools build system does not set OS_ defines #963

Closed
ryandesign opened this issue May 7, 2022 · 2 comments
Closed

Autotools build system does not set OS_ defines #963

ryandesign opened this issue May 7, 2022 · 2 comments

Comments

@ryandesign
Copy link
Contributor

The cmake build system sets some custom defines for various OS types in CMakeLists.txt

if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
  add_definitions(-DOS_LINUX)
elseif(${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD")
  add_definitions(-DOS_FREEBSD)
elseif(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
  add_definitions(-DOS_MACOSX)
endif()

The undocumented autotools build system does not. Perhaps it should?

@eustas
Copy link
Collaborator

eustas commented Jan 6, 2023

TODO: add the following definitions to Bazel / naked make / autotools:

  • OS_LINUX
  • OS_FREEBSD
  • OS_MACOSX
  • BROTLI_HAVE_LOG2

@eustas
Copy link
Collaborator

eustas commented Jul 10, 2023

Only Bazel left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants