Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"latest"tag in gcr.io is not getting updated #3066

Open
asloan7 opened this issue Feb 18, 2022 · 6 comments
Open

"latest"tag in gcr.io is not getting updated #3066

asloan7 opened this issue Feb 18, 2022 · 6 comments

Comments

@asloan7
Copy link

asloan7 commented Feb 18, 2022

Current "latest" release here in github is 0.39.3, but in
https://console.cloud.google.com/gcr/images/cadvisor/GLOBAL/cadvisor
it is still tagged to 0.38.6 from 14 months ago (Dec. 2020)

@asloan7 asloan7 changed the title Latest in gcr.io is not getting updated "latest"tag in gcr.io is not getting updated Feb 18, 2022
@calvinbui
Copy link

calvinbui commented May 24, 2022

agreed. the latest tag should be changed to 0.39.3. That version is the last non pre-release on GitHub.

@HoroTW
Copy link

HoroTW commented Aug 11, 2022

Now its 20 months old... This seems bad because I guess most people would not see that the latest tag is that old...
we are on version 0.45.0 and the latest tag is still pointing to 0.38.6 ....

@HoroTW
Copy link

HoroTW commented Aug 11, 2022

#3028 Also wants this fixed
#2542 Gives an explanation that sounds like the "latest" label is fixed on the version and can't be updated....
I don't see why this would be good... Normally I would like to know (and even update by using the "latest" tag)..

Can this be changed, or is there a reason I just overlooked?

@cocoonkid
Copy link

I ran into this today too.

Please for the love of god ;-)

@Corfucinas
Copy link

Corfucinas commented Jul 8, 2023

You can have a semver and latest too :-)

#!/usr/bin/env bash 
 #encoding=utf8 
  
 set -euox pipefail 
 IFS=$'\n\t' 
  
 export DOCKER_BUILDKIT=1 
 cd "$(dirname "$0")/.." 
  
 if [ -d .git ]; then 
     COMMIT_SHA=$(git rev-parse HEAD) 
     TAG_NAME=$(git describe --tags --abbrev=0) 
     REPO_NAME="Checkout of $(git remote get-url origin) at $(git describe --dirty --always)" 
     BRANCH_NAME=$(git rev-parse --abbrev-ref HEAD) 
 fi 
  
 docker build \ 
     --build-arg "COMMIT_SHA=$COMMIT_SHA" \ 
     --build-arg "REPO_NAME=$REPO_NAME" \ 
     --build-arg "BRANCH_NAME=$BRANCH_NAME" \ 
     --build-arg "TAG_NAME=$TAG_NAME" \ 
     -t cadvisor:"$TAG_NAME" \ 
     -t cadvisor:latest \
     -f docker/Dockerfile .

@HoroTW
Copy link

HoroTW commented Nov 30, 2023

Hi, this is still an issue and just unexpected behavior (from a user's point of view)...
The workaround suggested by @Corfucinas is nice if you really want the "latest" (in terms of most recent version).
For me, I wanted the latest version that was considered stable, basically the version tagged as latest on the releases page of github.....
For this version, I wanted the already built image from gcr - so yes, I also ended up with a script

Screenshot_20231130_121416
I tried to keep it simple, but also wanted some sanity checks - so it got a few lines long ^^
https://github.com/HoroTW/cadvisor-latest-stable-updater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants