Non-default aspect ratio will be ignored w/ Camera2

[foooorsyth]

In Camera2.setAspectRatio(AspectRatio ratio), you have this check at the start of the method:

if (ratio == null || ratio.equals(mAspectRatio) ||
                **!mPreviewSizes.ratios().contains(ratio)**) {
            // TODO: Better error handling
            return;
}

setAspectRatio() is called in the constructor of CameraView once the custom XML attribute value for app:aspectRatio is retrieved. At this time mPreviewSizes.ratios() will always be empty because camera info has not been collected yet, which happens on Camera2.start(). So, this method will always return without doing anything, and the default aspect ratio -- 4:3 -- will always be used.

I fixed this by collecting camera info before this check

chooseCameraIdByFacing();
collectCameraInfo();
if (ratio == null || ratio.equals(mAspectRatio) ||
                !mPreviewSizes.ratios().contains(ratio)) {
            // TODO: Better error handling
            return;
}

[gregkorossy]

This bug is still present...